Comments by "" (@plato4ek) on "ArjanCodes" channel.

  1. Actually pytest shows the coverage of 82% for `test_order.py`, which gives a hint. So it's not a 100% coverage.
    4
  2. No, it's not OK. It's a bug caused by copy-paste, and it prevents one of the tests from running.
    4
  3. 9:05 So, in essence, you create a mock and put this mock under test. This is not a proper way to do testing.
    3
  4. The middle segment of the video has a slightly out-of-sync audio.
    3
  5. 16:04 But the test fails on total_agrees(), not on remove_line_item_from_order_raises_error()
    1
  6. 9:00 Shouldn't the expression on the 48th line be inside the try-finally block? Seems like the `yield database` on its own cannot throw an exception.
    1
  7. these are the same
    1
  8. If you move "B -->|Yes| E" in front of "B -->|No| C(Enter email)" the resulting diagram will be less intertwined, and I guess it'll be exactly what you are talking about at 8:59. Full example: ```mermaid flowchart S[Start] --> A(Enter email) A --> B{Existing user?} B -->|Yes| E B -->|No| C(Enter email) conditions D -->|No| A D -->|Yes| E(Send email with the magic link) E --> End ```
    1
  9. 10:46 Why is there only `yield db` inside the try block? I guess this cannot raise an exception in any circumstances. Shouldn't the `db = SessionLocal()` also be inside the try block?
    1
  10. 4:27 I just want еще note that this is actually is not a quicksort algorithm, although it looks like one. The most important property of quicksort is that it is made in-place and thus uses O(log n) memory.
    1
  11. Hey, Arjan! 1:21 What tab-completion in a terminal app are you talking about? isn't that a feature of a shell, and not the terminal emulator?
    1
  12.  @marcosbarranquero8289  zsh is a shell. So it's not a completion in the terminal app, right?
    1
  13. 10:00 Same here. Shouldn't the `session_local()` call also be inside the try-finally block? Looks like `yield database` cannot throw an exception by its own.
    1
  14. Hi, Arjan. I wonder, did you watch some ThePrimeagen's videos?
    1