Comments by "" (@defeqel6537) on "Git Flow Is A Bad Idea" video.

@matthewlothian5865 I've seen enough silly changes to (all kinds of) tests made by developers to have learned not to trust tests to reveal issues from other developers
10
@ContinuousDelivery Fair enough. Unfortunately, bad developers, and just bad days for good/average developers, are a reality, and reviewing their code before merging it is often a necessary evil.
10
@andrealaforgia5066 It isn't up to me in the first place, might not be possible because of worker protection laws here in Europe, and those bad developers might not even be from the same company.
3
@ContinuousDelivery Mob programming might be the answer, but a junior developer paired with a senior one isn't as likely to notice mistakes from the senior developer (who just happens to make a mistake) and also less likely to vocalize it, and rarely there are enough seniors to go around to pair them up with each other. Mob programming is quite expensive time-to-"working lines of code" wise though compared to reviewing the PRs. Like you indicate, it's all about what fits which team (and management). We've certainly incorporated pair programming to our practices from time to time.
3
@ContinuousDelivery I'm sure both pair and mob programming are a matter of simply practicing (as is everything, I guess). I'm not sure I'm willing to completely let go of PR reviews, but increasing the amount of pair/mob programming sessions bit-by-bit seems doable.
2
@Timur21 to me that sounds like a great way to CREATE bugs while fixing them Personally I think that the unit of code under test should be a module that has more than a single client, whether that client is the end user or another module. If only a single other module is the user, then those modules should be tested together.
1
@Timur21 not having enough tests for the existing functionality while fixing bugs is prone to creating new bugs
1